linux-kernel - Re: [take4 1/4] kevent: Core files.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060805181047.GA22177@2ka.mipt.ru>
Date:	Sat, 5 Aug 2006 22:10:47 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Greg KH <greg@...ah.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Ulrich Drepper <drepper@...hat.com>,
	netdev <netdev@...r.kernel.org>,
	Zach Brown <zach.brown@...cle.com>
Subject: Re: [take4 1/4] kevent: Core files.

On Sat, Aug 05, 2006 at 10:57:02AM -0700, GregKH (greg@...ah.com) wrote:
> > +	dev = class_device_create(kevent_user_class, NULL, 
> > +			MKDEV(kevent_user_major, 0), NULL, kevent_name);
> > +	if (IS_ERR(dev)) {
> > +		printk(KERN_ERR "Failed to create %d.%d class device in \"%s\" class: err=%ld.\n", 
> > +				kevent_user_major, 0, kevent_name, PTR_ERR(dev));
> > +		err = PTR_ERR(dev);
> > +		goto err_out_class_destroy;
> > +	}
> 
> As you are only using 1 minor number in this code, why not just use a
> miscdevice instead?  It saves a bit of overhead and makes the code a
> tiny bit smaller :)

No problem. I will move it to miscdevice instead of full chardev.

> thanks,
> 
> greg k-h

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/