[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <44D41DEF.7040301@vmware.com>
Date: Fri, 04 Aug 2006 21:26:23 -0700
From: Zachary Amsden <zach@...are.com>
To: Chuck Ebbert <76306.1226@...puserve.com>
Cc: Jeremy Fitzhardinge <jeremy@...source.com>,
Jeremy Fitzhardinge <jeremy@...p.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
virtualization <virtualization@...ts.osdl.org>,
Xen-devel <xen-devel@...ts.xensource.com>,
Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [patch 3/8] Allow a kernel to not be in ring 0.
Chuck Ebbert wrote:
> In-Reply-To: <20060803002518.190834642@...source.com>
>
> On Wed, 02 Aug 2006 17:25:13 -0700, Jeremy Fitzhardinge wrote:
>
>
>> We allow for the fact that the guest kernel may not run in ring 0.
>> This requires some abstraction in a few places when setting %cs or
>> checking privilege level (user vs kernel).
>>
>
> I made some changes:
>
> a. Added some comments about the SEGMENT_IS_*_CODE() macros.
> b. Added a USER_RPL macro. (You were comparing a value to a mask
> in some places and to the magic number 3 in other places.)
> c. Changed the entry.S tests for LDT stack segment to use the macros.
>
These changes look great. Ack-ed. I had some similar ones before that
never made it from my tree, as I got carried away and tried to unify the
user descriptor conversion functions... someday I'll get to it again.
Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists