linux-kernel - Re: [PATCH][Doc] Fix kerneldoc comments in kernel/timer.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20060806133729.b389f1be.rdunlap@xenotime.net>
Date:	Sun, 6 Aug 2006 13:37:29 -0700
From:	"Randy.Dunlap" <rdunlap@...otime.net>
To:	Rolf Eike Beer <eike-kernel@...tec.de>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][Doc] Fix kerneldoc comments in kernel/timer.c

On Tue, 1 Aug 2006 16:31:39 +0200 Rolf Eike Beer wrote:

> Some of the kerneldoc comments in this file are ignored since the lead-in is
> malformed, using either "/*" or "/***" instead of "/**".
> 
> Signed-off-by: Rolf Eike Beer <eike-kernel@...tec.de>

> @@ -401,7 +405,7 @@ static int cascade(tvec_base_t *base, tv
>  	return index;
>  }
>  
> -/***
> +/**
>   * __run_timers - run all expired timers (if any) on this CPU.
>   * @base: the timer vector to be processed.
>   *

Thanks for the patch, Eike.  I noticed that __run_timers needs
some help.  Patch below.

---
From: Randy Dunlap <rdunlap@...otime.net>

Fix function description + definition so that a #macro does
not come between them and interfere with the kernel-doc.

Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
---
 kernel/timer.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2618-rc3g2.orig/kernel/timer.c
+++ linux-2618-rc3g2/kernel/timer.c
@@ -405,6 +405,8 @@ static int cascade(tvec_base_t *base, tv
 	return index;
 }
 
+#define INDEX(N) ((base->timer_jiffies >> (TVR_BITS + (N) * TVN_BITS)) & TVN_MASK)
+
 /**
  * __run_timers - run all expired timers (if any) on this CPU.
  * @base: the timer vector to be processed.
@@ -412,8 +414,6 @@ static int cascade(tvec_base_t *base, tv
  * This function cascades all vectors and executes all expired timer
  * vectors.
  */
-#define INDEX(N) ((base->timer_jiffies >> (TVR_BITS + (N) * TVN_BITS)) & TVN_MASK)
-
 static inline void __run_timers(tvec_base_t *base)
 {
 	struct timer_list *timer;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/