linux-kernel - Re: [PATCH] [MMC] Fix base address configuration in wbsd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060806141310.607a6e40.rdunlap@xenotime.net>
Date:	Sun, 6 Aug 2006 14:13:10 -0700
From:	"Randy.Dunlap" <rdunlap@...otime.net>
To:	Pierre Ossman <drzeus-list@...eus.cx>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [MMC] Fix base address configuration in wbsd

On Sun, 06 Aug 2006 22:57:35 +0200 Pierre Ossman wrote:

> Russell King wrote:
> > On Sun, Aug 06, 2006 at 10:22:23PM +0200, Pierre Ossman wrote:
> >> There were some confusion about base I/O variables in the wbsd driver.
> >> Seems like things have been working on shear luck so far. The global 'io'
> >> variable (used when manually configuring the resources) was used instead of
> >> the local 'base' variable.
> > 
> > Applied, thanks.
> > 
> > Shouldn't "base" be something other than "int" (eg, unsigned long) ?
> 
> unsigned short would probably be the right<tm> thing as the resource is
> 16 bits. I haven't seen it as big enough issue to warrant a patch.

and why not <resource_size_t> ?

> > Also, wbsd_init() takes base, irq, dma but passes wbsd_request_resources
> > io, irq and dma?  I suspect more fixes are on their way... 8)
> 
> *sigh*
> 
> And I thought this brown paper bag was just temporary...


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/