linux-kernel - Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060805113703.GD4506@ucw.cz>
Date:	Sat, 5 Aug 2006 11:37:04 +0000
From:	Pavel Machek <pavel@....cz>
To:	Andrew Morton <akpm@...l.org>
Cc:	Rolf Eike Beer <eike-kernel@...tec.de>, trivial@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h

Hi!

> > We have BUG_ON() right for this, don't we?
> 
> Well yes, but there are over a thousand BUG->BUG_ON conversion
> possibilities in the tree.  If people start sending them three-at-a-time
> we'll all go mad.
> 
> So.  If we're going to do this, bigger patches, please.

If we are going that way... I guess we should specify if BUG_ON() has
to evaluate its arguments even if it is compiled out...

Or probably better pecify that BUG_ON() must not have side effects?

							Pavel
-- 
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/