linux-kernel - [PATCH] megaraid: Use the proper type to hold the irq number.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <m1ejvsfttx.fsf@ebiederm.dsl.xmission.com>
Date:	Mon, 07 Aug 2006 09:28:58 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Andrew Morton <akpm@...l.org>
Cc:	Neela Syam Kolli <Neela.Kolli@...enio.com>,
	linux-scsi@...r.kernel.org,
	"Protasevich, Natalie" <Natalie.Protasevich@...SYS.com>,
	<linux-kernel@...r.kernel.org>
Subject: [PATCH] megaraid: Use the proper type to hold the irq number.


When testing on a Unisys machine it was discovered that
the megaraid driver would not initialize as it was
requesting irq 162 instead of irq 1442 it was assigned.
The problem was the irq number had been truncated by being
stored in an unsigned char.

This patches fixes that problem and the driver now appears
to work.

The ioctl interface appears fundamentally broken as it exports
the irq number to user space in an unsigned char. 

Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
---
 drivers/scsi/megaraid/mega_common.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/megaraid/mega_common.h b/drivers/scsi/megaraid/mega_common.h
index 8cd0bd1..b50e27e 100644
--- a/drivers/scsi/megaraid/mega_common.h
+++ b/drivers/scsi/megaraid/mega_common.h
@@ -175,7 +175,7 @@ typedef struct {
 	uint8_t			max_lun;
 
 	uint32_t		unique_id;
-	uint8_t			irq;
+	int			irq;
 	uint8_t			ito;
 	caddr_t			ibuf;
 	dma_addr_t		ibuf_dma_h;
-- 
1.4.2.rc3.g7e18e

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/