linux-kernel - Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41840b750608070930p59a250a4l99c07260229dda8e@mail.gmail.com>
Date:	Mon, 7 Aug 2006 19:30:55 +0300
From:	"Shem Multinymous" <multinymous@...il.com>
To:	"Pavel Machek" <pavel@...e.cz>
Cc:	"Robert Love" <rlove@...ve.org>,
	"Jean Delvare" <khali@...ux-fr.org>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, hdaps-devel@...ts.sourceforge.net
Subject: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

Hi Pavel,

On 8/7/06, Pavel Machek <pavel@...e.cz> wrote:
> > +     int total, ret;
> > +     for (total=READ_TIMEOUT_MSECS; total>0; total-=RETRY_MSECS) {
>
> Could we go from 0 to timeout, not the other way around?

Sure.
(That's actually vanilla hdapsd code, moved around...)


> This actually changes userland interface... but that is probably okay.

Those two sysfs attributes were bogus. If anything used them (which I
very much doubt), it's a good thing we broke it.

OK on the rest.

  Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/