| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <m1slk89ozd.fsf@ebiederm.dsl.xmission.com> Date: Mon, 07 Aug 2006 16:10:14 -0600 From: ebiederm@...ssion.com (Eric W. Biederman) To: Andrew Morton <akpm@...l.org> Cc: "Randy.Dunlap" <rdunlap@...otime.net>, Andi Kleen <ak@...e.de>, "Protasevich, Natalie" <Natalie.Protasevich@...SYS.com>, <linux-kernel@...r.kernel.org> Subject: [PATCH] x86_64: Make NR_IRQS configurable in Kconfig Currently on a SMP system we can theoretically support NR_CPUS*224 irqs. Unfortunately our data structures don't cope will with that many irqs, nor does hardware typically provide that many irq sources. With the number of cores starting to follow Moore's Law, and the apicid limits being raised beyond an 8bit number trying to track our current maximum with our current data structures would be fatal and wasteful. So this patch decouples the number of irqs we support from the number of cpus. We can revisit this decision once someone reworks the current data structures. This version has my stupid typos fixed and the true maximum exposed to make it clear that I have a low default. The worst that I can see happening is there won't be any per_cpu space left for modules if someone sets this too high, but the system should still boot. For non-SMP systems the default is no set to 224 IRQs. The description has been reworded in an attempt to make it clear what this option controls. Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com> --- arch/x86_64/Kconfig | 25 +++++++++++++++++++++++++ include/asm-x86_64/irq.h | 3 ++- 2 files changed, 27 insertions(+), 1 deletions(-) diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig index 7598d99..adcbb21 100644 --- a/arch/x86_64/Kconfig +++ b/arch/x86_64/Kconfig @@ -384,6 +384,31 @@ config NR_CPUS This is purely to save memory - each supported CPU requires memory in the static kernel configuration. +config NR_IRQS + int "Maximum number of IRQs (224-57344)" + range 224 57344 + default "4096" if SMP + default "224" if !SMP + help + This option allows you to specify the maximum number of interrupt + sources your kernel will support. Architecturally there are + 224 interrupt destinations per cpu, so setting to a higher value + can be wasteful. + + Many machines have irq controllers with unconnected interrupt + pins, leading to unused irq numbers in the kernel. Since a + destination is not assigned to an unused interrupt source + it can be reasonable to support more interrupt sources then + there are destinations to receive them. + + The current recommended value is 4096 as it is slightly more irqs + than any known machine and still small enough to have a + reasonable memory consumption. Setting a noticeably larger value + will exhaust your per cpu memory, and waste memory in the per irq + arrays. + + If unsure leave this at the default. + config HOTPLUG_CPU bool "Support for hot-pluggable CPUs (EXPERIMENTAL)" depends on SMP && HOTPLUG && EXPERIMENTAL diff --git a/include/asm-x86_64/irq.h b/include/asm-x86_64/irq.h index 5006c6e..b0f6460 100644 --- a/include/asm-x86_64/irq.h +++ b/include/asm-x86_64/irq.h @@ -31,7 +31,8 @@ #define NR_VECTORS 256 #define FIRST_SYSTEM_VECTOR 0xef /* duplicated in hw_irq.h */ -#define NR_IRQS (NR_VECTORS + (32 *NR_CPUS)) +/* We can be setup to receive at most NR_CPUS*224 irqs simultaneously */ +#define NR_IRQS (CONFIG_NR_IRQS) #define NR_IRQ_VECTORS NR_IRQS static __inline__ int irq_canonicalize(int irq) -- 1.4.2.rc3.g7e18e - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists