linux-kernel - Re: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060807231728.GB2759@elf.ucw.cz>
Date:	Tue, 8 Aug 2006 01:17:28 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Björn Steinbrink <B.Steinbrink@....de>,
	Shem Multinymous <multinymous@...il.com>,
	Robert Love <rlove@...ve.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, hdaps-devel@...ts.sourceforge.net
Subject: Re: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access

Hi!

> > >> >> +     struct dmi_device *dev = NULL;
> > >> >unneeded initializer.
> > >> On a local variable?!
> > >
> > >You assign a new value to it on the next line, without ever using its
> > >initial value.
> > 
> > The initial value is used in the last parameter to dmi_find_device():
> > 
> > 	struct dmi_device *dev = NULL;
> > 	while ((dev = dmi_find_device(type, NULL, dev))) {
> > 		if (strstr(dev->name, substr))
> > 			return 1;
> > 	}
> 
> Sorry, somehow my brain skipped the end of the line.

Ahha, sorry about that, I was blind, too. I thought it is because the
code is ugly, but now I see I was wrong.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/