linux-kernel - Re: fctnl(F_SETSIG) no longer works in 2.6.17, does in 2.6.16.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1155043590.5673.13.camel@localhost>
Date:	Tue, 08 Aug 2006 09:26:30 -0400
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Beschorner Daniel <Daniel.Beschorner@...ton.com>
Cc:	linux-kernel@...r.kernel.org, orion@...a.nwra.com,
	76306.1226@...puserve.com, sfr@...b.auug.org.au
Subject: Re: fctnl(F_SETSIG) no longer works in 2.6.17, does in 2.6.16.

On Tue, 2006-08-08 at 07:38 +0200, Beschorner Daniel wrote:
> >>> static void lease_release_private_callback(struct file_lock *fl) 
> >>> { 
> >>>         if (!fl->fl_file) 
> >>>                 return; 
> >>>         f_delown(fl->fl_file); 
> >>> =>      fl->fl_file->f_owner.signum = 0; 
> >>> } 
> 
> >> Why should the lease cleanup code be resetting f_owner.signum? That 
> >> looks wrong. 
> >> Stephen, I think this line of code predates the CITI changes. Do you 
> >> know who added it and why? 
> 
> >Because when the original code was written, it was only called when we
> got 
> >a fcntl(F_SETLEASE, F_UNLCK) call.  The code got moved incorrectly and 
> >noone noticed.
> 
> Does somebody have a patch for this issue? It breaks one important
> application (Samba) in its default configuration.
> 
> Daniel

I believe this ought to fix it.

Cheers,
  Trond


Download attachment "linux-2.6.18-fix_lease_signals.dif" of type "message/rfc822" (1244 bytes)