linux-kernel - Re: [PATCH 10/12] hdaps: Power off accelerometer on suspend and unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Aug 2006 16:28:59 +0300
From:	"Shem Multinymous" <multinymous@...il.com>
To:	"Pavel Machek" <pavel@...e.cz>
Cc:	"Robert Love" <rlove@...ve.org>,
	"Jean Delvare" <khali@...ux-fr.org>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, hdaps-devel@...ts.sourceforge.net
Subject: Re: [PATCH 10/12] hdaps: Power off accelerometer on suspend and unload

Hi,

On 8/8/06, Pavel Machek <pavel@...e.cz> wrote:
> > +     if (hdaps_set_power(0))
> > +             printk(KERN_WARNING "hdaps: cannot power off\n");
> > +     if (hdaps_set_ec_config(0, 1))
> > +             printk(KERN_WARNING "hdaps: cannot stop EC sampling\n");
> > +}
>
> Maybe propagate error value?

I could do that, but both callers will still discard it -- the power
draw change is negligible, and it's not interesting enough to abort
either suspend or module unload.

OK on all remaining comments.

I'll wait a bit for additional comments and then post the revised series.

  Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/