linux-kernel - Re: [BUG] futex_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1155026312.7331.12.camel@Homer.simpson.net>
Date:	Tue, 08 Aug 2006 08:38:32 +0000
From:	Mike Galbraith <efault@....de>
To:	john stultz <johnstul@...ibm.com>
Cc:	Ingo Molnar <mingo@...e.hu>, lkml <linux-kernel@...r.kernel.org>,
	rusty@...tcorp.com.au, jakub@...hat.com
Subject: Re: [BUG] futex_handle_fault always fails.

On Mon, 2006-08-07 at 14:39 -0700, john stultz wrote:
> The following patch addresses these two issues by 1) Always setting ret
> to -EFAULT if futex_handle_fault fails, and 2) Removing the = in
> futex_handle_fault's (attempt >= 2) check.

Nit:  why not use the return value directly instead of translating that
return (-EFAULT) into -EFAULT?

	-Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/