linux-kernel - Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41840b750608090202k4dcac1b3h38c1f98d398af479@mail.gmail.com>
Date:	Wed, 9 Aug 2006 12:02:39 +0300
From:	"Shem Multinymous" <multinymous@...il.com>
To:	"Muli Ben-Yehuda" <muli@...ibm.com>
Cc:	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Pavel Machek" <pavel@...e.cz>,
	"Björn Steinbrink" <B.Steinbrink@....de>,
	"Robert Love" <rlove@...ve.org>,
	"Jean Delvare" <khali@...ux-fr.org>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, hdaps-devel@...ts.sourceforge.net
Subject: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes

On 8/9/06, Muli Ben-Yehuda <muli@...ibm.com> wrote:
> > >If the concern is just the naming then change it to end _trylock
> >
> > We already have a thinkpad_ec_trylock() for the non-blocking
> > variant.
>
> thinkpad_ec_down_interruptible()?

Just ran out, of that sir,

If we'll need to lock away ACPI (just matter of time, my guess), we'll
stumble upon the non-interruptible down()s deep inside in the ACPI
code. So we can't guarantee and shouldn't promise it's really
interruptible.

It's not that strange that a function might fail even if it's named
"do_something()", you know. It's down() that forms an exception - it's
so simple we know it can't fail.

  Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/