linux-kernel - Re: [PATCH 5/6] clean up OCFS2 nlink handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Aug 2006 18:12:53 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Dave Hansen <haveblue@...ibm.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, hch@...radead.org
Subject: Re: [PATCH 5/6] clean up OCFS2 nlink handling

On Wed, Aug 09, 2006 at 09:57:33AM -0700, Dave Hansen wrote:
> 
> OCFS2 does some operations on i_nlink, then reverts them if some
> of its operations fail to complete.  This does not fit in well
> with the drop_nlink() logic where we expect i_nlink to stay at
> zero once it gets there.
> 
> So, delay all of the nlink operations until we're sure that the
> operations have completed.  Also, introduce a small helper to
> check whether an inode has proper "unlinkable" i_nlink counts
> no matter whether it is a directory or regular inode.
> 
> This patch is broken out from the others because it does contain
> some logical changes.

looks good to me, although I probably can't ACK ocfs2 patches.  did you
look whether gfs2 in -mm needs something similar?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/