linux-kernel - Re: lockdep: fix smc91x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060809232912.GA29587@flint.arm.linux.org.uk>
Date:	Thu, 10 Aug 2006 00:29:13 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Linux Kernel List <linux-kernel@...r.kernel.org>,
	Arjan Van de Ven <arjan@...radead.org>,
	Ingo Molnar <mingo@...e.hu>, Nicolas Pitre <nico@....org>
Subject: Re: lockdep: fix smc91x

On Tue, Aug 08, 2006 at 11:45:28PM -0400, Jeff Garzik wrote:
> Russell King wrote:
> >Hi,
> >
> >When booting using root-nfs, I'm seeing (independently) two lockdep dumps
> >in the smc91x driver.  The patch below fixes both.  Both dumps look like
> >real locking issues.
> >
> >Nico - please review and ack if you think the patch is correct.
> 
> Was this ever ACK'd?

Not afaik.

> I would prefer spin_lock_irqsave(), but that's just a quibble.  I would 
> be OK with applying this.

Yes, though I did review all call paths to make sure it was safe first.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/