linux-kernel - Re: [PATCH 02/06] i386: remove redundant generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200608090420.06156.ak@suse.de>
Date:	Wed, 9 Aug 2006 04:20:06 +0200
From:	Andi Kleen <ak@...e.de>
To:	Magnus Damm <magnus@...inux.co.jp>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [PATCH 02/06] i386: remove redundant generic_identify() calls when identifying cpus

On Wednesday 09 August 2006 03:03, Magnus Damm wrote:
> i386: remove redundant generic_identify() calls when identifying cpus
> 
> cpu_dev->c_identify is only called from arch/i386/common.c:identify_cpu(), and
> this after generic_identify() already has been called. There is no need to call
> this function twice and hook it in c_identify - but I may be wrong, please
> double check before applying.
> 
> This patch also removes generic_identify() from cpu.h to avoid unnecessary
> future nesting.

There are sometimes subtle interactions with this (e.g. with parameters
changing flags and then someone else overwriting them again)

But agreed it seems bogus to call it twice.

I guess the only way to find out how much it breaks is to merge it.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/