[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <p738xlyo76g.fsf@verdi.suse.de>
Date: 09 Aug 2006 06:37:59 +0200
From: Andi Kleen <ak@...e.de>
To: Christoph Hellwig <hch@...radead.org>
Cc: linux-kernel@...r.kernel.org,
Prasanna S Panchamukhi <prasanna@...ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
Jim Keniston <jkenisto@...ibm.com>
Subject: Re: [PATCH 2/3] Kprobes: Define retval helper
Christoph Hellwig <hch@...radead.org> writes:
> On Mon, Aug 07, 2006 at 05:30:24PM +0530, Ananth N Mavinakayanahalli wrote:
> > From: Ananth N Mavinakayanahalli <ananth@...ibm.com>
> >
> > Add the KPROBE_RETVAL macro to help extract the return value on
> > different architectures, while using function-return probes.
>
> Good idea. You should add parentheses around regs, otherwise the C
> preprocessor might bite users. Also the shouting name is quite ugly.
> In fact it should probably go to asm/system.h or similar
The other macros like this (instruction_pointer etc) are in asm/ptrace.h
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists