linux-kernel - Re: [PATCH] kill extraneous printk in kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <m13bbtwfxq.fsf@ebiederm.dsl.xmission.com>
Date:	Fri, 18 Aug 2006 21:41:05 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Cal Peake <cp@...olutedigital.net>
Cc:	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] kill extraneous printk in kernel_restart()

Cal Peake <cp@...olutedigital.net> writes:

> Hi,
>
> Is there a reason for printing a single dot and newline in 
> kernel_restart()? If not, below is a one-liner to kill it.

Hmm.  This looks like a thinko from my original patch.

Signed-off-By: Eric W. Biederman <ebiederm@...ssion.com>

> -- 
>
> Get rid of an extraneous printk in kernel_restart().
>
> Signed-off-by: Cal Peake <cp@...olutedigital.net>
>
> --- linux-2.6.18-rc4/kernel/sys.c~orig	2006-08-07 22:00:27.000000000 -0400
> +++ linux-2.6.18-rc4/kernel/sys.c	2006-08-18 16:52:52.000000000 -0400
> @@ -611,7 +611,6 @@ void kernel_restart(char *cmd)
>  	} else {
>  		printk(KERN_EMERG "Restarting system with command '%s'.\n", cmd);
>  	}
> -	printk(".\n");
>  	machine_restart(cmd);
>  }
>  EXPORT_SYMBOL_GPL(kernel_restart);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/