lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060819101717.GA26267@electric-eye.fr.zoreil.com>
Date:	Sat, 19 Aug 2006 12:17:17 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Jesse Huang <jesse@...lus.com.tw>
Cc:	penberg@...Helsinki.FI, akpm@...l.org, dvrabel@...tab.net,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	david@...yades.net
Subject: Re: [PATCH 5/7] ip1000: Modify coding style of ipg_config_autoneg()

Jesse Huang <jesse@...lus.com.tw> :
> From: Jesse Huang <jesse@...lus.com.tw>
> 
> This is only coding style modify for ipg_config_autoneg(). Thanks for the
> suggestion form Francois.
> 
> Change Logs:
>     Modify coding style of ipg_config_autoneg()
> 
> ---
> 
>  drivers/net/ipg.c |   17 ++++++++++-------
>  1 files changed, 10 insertions(+), 7 deletions(-)
> 
> 737498ca620437d8179e21be4d5220333066cbbd
> diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c
> index f859107..be96f93 100644
> --- a/drivers/net/ipg.c
> +++ b/drivers/net/ipg.c
> @@ -491,11 +491,13 @@ static int ipg_config_autoneg(struct net
>  	int fullduplex;
>  	int txflowcontrol;
>  	int rxflowcontrol;
> +	long MacCtrlValue;

Mixed case variables are not exactly welcome.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ