linux-kernel - Re: [Patch] Signdness issue in drivers/scsi/osst.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1156097917.4051.30.camel@localhost.localdomain>
Date:	Sun, 20 Aug 2006 19:18:37 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Eric Sesterhenn <snakebyte@....de>
Cc:	linux-kernel@...r.kernel.org, osst@...de.org
Subject: Re: [Patch] Signdness issue in drivers/scsi/osst.c

Ar Sad, 2006-08-19 am 21:19 +0200, ysgrifennodd Eric Sesterhenn:
> Hi,
> 
> another signdness warning from gcc 4.1
> 
> drivers/scsi/osst.c:5154: warning: comparison of unsigned expression < 0 is always false
> 
> The problem is that blk is defined as unsigned, but all usages of it
> are normal int cases. osst_get_frame_position() and osst_get_sector()
> return ints and can return negative values. If blk stays an unsigned int,
> the error check is useless.


Acked-by: Alan Cox <alan@...hat.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/