linux-kernel - Re: [Patch] Signedness issue in drivers/net/3c515.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1156098152.4051.34.camel@localhost.localdomain>
Date:	Sun, 20 Aug 2006 19:22:32 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Eric Sesterhenn <snakebyte@....de>
Cc:	linux-kernel@...r.kernel.org, becker@...ld.com, jgarzik@...ox.com
Subject: Re: [Patch] Signedness issue in drivers/net/3c515.c

Ar Sad, 2006-08-19 am 19:37 +0200, ysgrifennodd Eric Sesterhenn:
> hi,
> 
> while playing with gcc 4.1 -Wextra warnings, I came across this one:
> 
> drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is always true
> 
> Since i is unsigned the >= 0 check in the for loop is always true,
> so we might spin there forever unless the if condition triggers.
> Since i is only used in this loop, this patch changes it to
> an integer.
> 
> Signed-off-by: Eric Sesterhenn <snakebyte@....de>
> 

Acked-by: Alan Cox <alan@...hat.com>

[And put JG on the Cc:]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/