linux-kernel - Re: [PATCH] char/moxa.c: fix endianess and multiple-card issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1156098529.4051.40.camel@localhost.localdomain>
Date:	Sun, 20 Aug 2006 19:28:48 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dirk Eibach <eibach@...ys.de>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [PATCH] char/moxa.c: fix endianess and multiple-card issues

Ar Gwe, 2006-08-18 am 13:39 +0200, ysgrifennodd Dirk Eibach:
> From: Dirk Eibach <eibach@...ys.de>
> 
> While testing Moxa C218T/PCI on PowerPC 405EP I found that loading 
> firmware using the linux kernel driver fails because calculation of the 
> checksum is not endianess independent in the original code.

> Signed-off-by: Dirk Eibach <eibach@...ys.de>

Acked-by: Alan Cox <alan@...hat.com>

Checksum changes are clearly correct. Other changes is an improvement
but not I think enough to handle malicious firmware attacks. That said
such an attacker has CAP_SYS_RAWIO anyway so that part is irrelevant
except for neatness

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/