linux-kernel - Re: [Patch] Signedness issue in drivers/net/phy/phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 Aug 2006 06:12:02 +0200
From:	Richard Knutsson <ricknu-0@...dent.ltu.se>
To:	Eric Sesterhenn <snakebyte@....de>
CC:	linux-kernel@...r.kernel.org, drzeus-sdhci@...eus.cx
Subject: Re: [Patch] Signedness issue in drivers/net/phy/phy_device.c

Eric Sesterhenn wrote:

>hi,
>  
>
hello

>while checking gcc 4.1 -Wextra warnings, I stumbled across the following
>two warnings:
>
>drivers/net/phy/phy_device.c:528: warning: comparison of unsigned expression < 0 is always false
>drivers/net/phy/phy_device.c:546: warning: comparison of unsigned expression < 0 is always false
>
>Since phy_read() returns an integer and can return negative values, it
>seems to me the best way to get proper error handling working again
>is to make val an int. Currently it is an u32, so the < 0 check
>always fails.
>
>Signed-off-by: Eric Sesterhenn <snakebyte@....de>
>
>--- linux-2.6.18-rc4/drivers/net/phy/phy_device.c.orig	2006-08-19 18:22:56.000000000 +0200
>+++ linux-2.6.18-rc4/drivers/net/phy/phy_device.c	2006-08-19 18:24:49.000000000 +0200
>@@ -513,7 +513,7 @@ EXPORT_SYMBOL(genphy_read_status);
> 
> static int genphy_config_init(struct phy_device *phydev)
> {
>-	u32 val;
>+	int val;
>  
>
Would it not be preferable to use a 's32' instead of an 'int'? After 
all, it seem 'val' needs to be 32 bits.

Just a thought
/Richard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/