linux-kernel - Re: [mm patch] drm, minor fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20060821141339.GD1919@slug>
Date:	Mon, 21 Aug 2006 14:13:39 +0000
From:	Frederik Deweerdt <deweerdt@...e.fr>
To:	airlied@...ux.ie
Cc:	Arjan van de Ven <arjan@...radead.org>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [mm patch] drm, minor fixes

(Sorry, I forgot to CCs.)
On Mon, Aug 21, 2006 at 12:22:42PM +0100, Dave Airlie wrote:
> >>
> >>are you sure the callers of these don't wrap it inside a DRM_ERR()
> >>macro ?
> >I changed the values when:
> >- I've checked what seemed right, getting back to the system call.
> > drm_ioctl(), through a call to func().
> > That's the case for:
> > - the EFAULT value in i915_emit_box
> > - two EINVAL values in drm_setversion
> >- the return value wasn't used. That was the case for
> > drm_set_busid return values, I felt having returned values negative
> > from the start was more consistent.
> >
> >Is there a particular change that looked suspicious to you?
> 
> [...], however I doubt any of the codepaths are causing a major problem [...]
I agree, I just corrected those because I happen to stumble upon them.
I've tried a kernel with those corrections alone, and it didn't changed
anything on the oopses.

Regards,
Frederik

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/