linux-kernel - Re: [PATCH] [DOCBOOK] fix segfault in docproc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20060821133547.dbb9ee4c.rdunlap@xenotime.net>
Date:	Mon, 21 Aug 2006 13:35:47 -0700
From:	"Randy.Dunlap" <rdunlap@...otime.net>
To:	Henne <henne@...htwindheim.de>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org,
	jgarzik <jgarzik@...ox.com>
Subject: Re: [PATCH] [DOCBOOK] fix segfault in docproc.c

On Mon, 21 Aug 2006 20:34:29 +0200 Henne wrote:

> From: Henrik Kretzschmar <henne@...htwindheim.de>
> 
> Adds a missing exit, if the file that should be parsed couldn't be opened.
> Without it crashes with a segfault, cause the filedescriptor is accessed even if the file could not be opened.
> This error happens on 2.6.18-rc4-mm[12] when executing make xmldocs.
> 
> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>

Thanks.

Acked-by: Randy Dunlap <rdunlap@...otime.net>

Could you also update Documentation/DocBook/libata.tmpl to use
drivers/ata/ instead of drivers/scsi/ on the !I and !E lines?


> ---
> 
> --- linux-2.6.18-rc4/scripts/basic/docproc.c	2006-06-18 03:49:35.000000000 +0200
> +++ linux/scripts/basic/docproc.c	2006-08-18 22:19:48.000000000 +0200
> @@ -177,6 +177,7 @@
>  		{
>  			fprintf(stderr, "docproc: ");
>  			perror(real_filename);
> +			exit(1);
>  		}
>  		while(fgets(line, MAXLINESZ, fp)) {
>  			char *p;
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/