linux-kernel - Re: 800+ byte inlines in include/net/pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060821.163801.15260979.davem@davemloft.net>
Date:	Mon, 21 Aug 2006 16:38:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hadi@...erus.ca
Cc:	vda.linux@...glemail.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: 800+ byte inlines in include/net/pkt_act.h

From: jamal <hadi@...erus.ca>
Date: Mon, 21 Aug 2006 08:26:00 -0400

> As per last discussion, either Patrick McHardy or myself are going
> to work on it - at some point. Please be patient. The other
> alternative is: you fix it and send patches.

I'm working on it right now.  This code is really gross and needs
to be fixed immediately.

What I'll do is define a "struct tcf_common" and have the generic
interfaces take that as well as a "struct tcf_hashinfo *" parameter to
deal with the individual hash tables.

We define all of this templated stuff then don't even use it in
act_police.c, we just duplicate everything!

Absolutely unbelievable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/