linux-kernel - Re: [PATCH] sys_ioprio_set: minor do_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060821062829.GG4290@suse.de>
Date:	Mon, 21 Aug 2006 08:28:30 +0200
From:	Jens Axboe <axboe@...e.de>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sys_ioprio_set: minor do_each_thread+break fix

On Sun, Aug 20 2006, Oleg Nesterov wrote:
> From include/linux/sched.h:
> 	/*
> 	 * Careful: do_each_thread/while_each_thread is a double loop so
> 	 *          'break' will not work as expected - use goto instead.
> 	 */
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>
> 
> --- 2.6.18-rc4/fs/ioprio.c~2_break	2006-07-16 01:53:08.000000000 +0400
> +++ 2.6.18-rc4/fs/ioprio.c	2006-08-20 18:57:38.000000000 +0400
> @@ -111,9 +111,9 @@ asmlinkage long sys_ioprio_set(int which
>  					continue;
>  				ret = set_task_ioprio(p, ioprio);
>  				if (ret)
> -					break;
> +					goto free_uid;
>  			} while_each_thread(g, p);
> -
> +free_uid:
>  			if (who)
>  				free_uid(user);
>  			break;

Good catch, applied!

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/