linux-kernel - Re: [PATCH] cfq_cic_link: fix? usage of wrong cfq_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060821062930.GJ4290@suse.de>
Date:	Mon, 21 Aug 2006 08:29:30 +0200
From:	Jens Axboe <axboe@...e.de>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cfq_cic_link: fix? usage of wrong cfq_io_context

On Mon, Aug 21 2006, Oleg Nesterov wrote:
> Obviously, cfq_cic_link() shouldn't free a just allocated cfq_io_context ?
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>
> 
> --- 2.6.18-rc4/block/cfq-iosched.c~7_set	2006-08-20 21:23:25.000000000 +0400
> +++ 2.6.18-rc4/block/cfq-iosched.c	2006-08-21 00:53:27.000000000 +0400
> @@ -1561,7 +1561,7 @@ restart:
>  		/* ->key must be copied to avoid race with cfq_exit_queue() */
>  		k = __cic->key;
>  		if (unlikely(!k)) {
> -			cfq_drop_dead_cic(ioc, cic);
> +			cfq_drop_dead_cic(ioc, __cic);
>  			goto restart;
>  		}

Yep, that's a typo. Applied.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/