linux-kernel - Re: [PATCH] 2.6.17.9 Incorrect string length checking in param_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0608211038480.22414@yvahk01.tjqt.qr>
Date:	Mon, 21 Aug 2006 10:39:03 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Julio Auto <mindvortex@...il.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 2.6.17.9 Incorrect string length checking in
 param_set_copystring()

>> As for 2.6.17.9, linux/include/linux/moduleparam.h suggests the user
>> of module_param_string() to set the maxlen parameter to
>> strlen(string), ie. '\0' excluded.
>
> Actually, sizeof(string), not strlen(string). Senseless typo here.
> Sorry, my bad. :)

With \0 excluded, you want strlen(string) or sizeof(string)-1.


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/