lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Aug 2006 23:10:37 +0400 From: Oleg Nesterov <oleg@...sign.ru> To: Ingo Molnar <mingo@...e.hu> Cc: Andrew Morton <akpm@...l.org>, Thomas Gleixner <tglx@...utronix.de>, Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] futex_find_get_task: remove an obscure EXIT_ZOMBIE check On 08/22, Ingo Molnar wrote: > > * Oleg Nesterov <oleg@...sign.ru> wrote: > > > (Compile tested). > > > > futex_find_get_task: > > > > if (p->state == EXIT_ZOMBIE || p->exit_state == EXIT_ZOMBIE) > > return NULL; > > > > I can't understand this. First, p->state can't be EXIT_ZOMBIE. The > > ->exit_state check looks strange too. Sub-threads or tasks whose > > ->parent ignores SIGCHLD go directly to EXIT_DEAD state (I am ignoring > > a ptrace case). Why EXIT_DEAD tasks should be ok? Yes, EXIT_ZOMBIE is > > more important (a task may stay zombie for a long time), but this > > doesn't mean we should explicitely ignore other EXIT_XXX states. > > > > Signed-off-by: Oleg Nesterov <oleg@...sign.ru> > > i believe this is a remnant of older times when EXIT_ZOMBIE was > introduced. We cloned that into the -rt tree, but then exit-state got > cleaned up (by you) No, no, it was Roland. But probably you are talking about these patches http://marc.theaimsgroup.com/?t=113284375800003&r=1 http://marc.theaimsgroup.com/?t=113284375800005&r=1 ? It was abandoned by Linus. It is not clear was he convinced or not, but I'd be happy to re-send this patch (on weekend) if you wish. Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists