linux-kernel - Re: [uml-devel] arch/um/sys-i386/setjmp.S: useless #ifdef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Aug 2006 22:20:12 -0400
From:	Jeff Dike <jdike@...toit.com>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	linux-kernel@...r.kernel.org,
	user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: [uml-devel] arch/um/sys-i386/setjmp.S: useless #ifdef _REGPARM's?

On Mon, Aug 21, 2006 at 11:56:41PM +0200, Adrian Bunk wrote:
> arch/um/sys-i386/setjmp.S contains two #ifdef _REGPARM's.
> 
> Even if regparm was used in i386 uml (which isn't currently done (why?)),
> I don't see _REGPARM being defined anywhere.

setjmp.S was stolen from klibc, and I'd just as soon leave it alone and
not try to customize it for UML.  That file will disappear if/when klibc 
is in mainline, and I can just pull it in from usr.

In general, there's no reason that regparam can't be used for UML.  However,
in the past (I don't know if it's still a problem) gcc miscompiled regparam
code in the presence of -pg.

As for why it's not, I don't see any occurences of regparam in include/linux
or include/asm-i386 either.

> Is this a bug waiting for happening when regparm will be used on uml or 
> do I miss anything?

Probably not.

				Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/