linux-kernel - [PATCH] Remove redundant up() in stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <67029b170608230327n580f8469m37a9dce00f73ea2f@mail.gmail.com>
Date:	Wed, 23 Aug 2006 18:27:27 +0800
From:	"Zhou Yingchao" <yingchao.zhou@...il.com>
To:	torvalds@...l.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] Remove redundant up() in stop_machine(2.6.18-rc4)

    An up() is called in kernel/stop_machine.c on failure, and also in
the caller unconditionally. I have reported, but now it is still here.

Signed-off-by: Zhou Yingchao <yingchao.zhou@...il.com>
___
--- kernel/stop_machine.c.orig	2006-08-23 14:53:36.000000000 +0800
+++ kernel/stop_machine.c	2006-08-23 14:53:55.000000000 +0800
@@ -111,7 +111,6 @@ static int stop_machine(void)
 	/* If some failed, kill them all. */
 	if (ret < 0) {
 		stopmachine_set_state(STOPMACHINE_EXIT);
-		up(&stopmachine_mutex);
 		return ret;
 	}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/