[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0608231003340.3198@d.namei>
Date: Wed, 23 Aug 2006 10:06:25 -0400 (EDT)
From: James Morris <jmorris@...ei.org>
To: Akinobu Mita <mita@...aclelinux.com>
cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
Patrick McHardy <kaber@...sh.net>,
David Miller <davem@...emloft.net>, akpm@...l.org
Subject: Re: call panic if nl_table allocation fails
On Wed, 23 Aug 2006, Akinobu Mita wrote:
> This patch makes crash happen if initialization of nl_table fails
> in initcalls. It is better than getting use after free crash later.
> nl_table = kcalloc(MAX_LINKS, sizeof(*nl_table), GFP_KERNEL);
Perhaps it'd be better to declare this as an array rather than allocating
it at runtime.
- James
--
James Morris
<jmorris@...ei.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists