linux-kernel - Serial custom speed deprecated?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Aug 2006 17:41:34 -0400
From:	"Stuart MacDonald" <stuartm@...necttech.com>
To:	"'LKML'" <linux-kernel@...r.kernel.org>, <dwmw2@...radead.org>
Subject: Serial custom speed deprecated?

From
http://www.kernel.org/pub/linux/kernel/v2.5/ChangeLog-2.5.64

"<dwmw2@...w2.baythorne.internal>
	Complain about setting custom speed or divisor on serial ports."

And the relevant patch hunk:
@@ -832,8 +826,17 @@
                goto exit;
        if (info->flags & UIF_INITIALIZED) {
                if (((old_flags ^ port->flags) & UPF_SPD_MASK) ||
-                   old_custom_divisor != port->custom_divisor)
+                   old_custom_divisor != port->custom_divisor) {
+                       /* If they're setting up a custom divisor or speed,
+                        * instead of clearing it, then bitch about it. No
+                        * need to rate-limit; it's CAP_SYS_ADMIN only. */
+                       if (port->flags & UPF_SPD_MASK) {
+                               printk(KERN_NOTICE "%s sets custom speed on %s%d. This is deprecated.\n",
+                                      current->comm, info->tty->driver.name,
+                                      info->port->line);
+                       }
                        uart_change_speed(info, NULL);
+               }
        } else
                retval = uart_startup(info, 1);
  exit:

If custom speeds are deprecated, what's the new method for setting
them? Specifically, how can the SPD_CUST functionality be accomplished
without that flag? I've checked 2.5.64 and 2.6.17, and don't see how
it is possible.

..Stu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/