linux-kernel - Re: [Devel] [PATCH 1/6] BC: kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1156372079.2510.723.camel@stark>
Date:	Wed, 23 Aug 2006 15:27:59 -0700
From:	Matt Helsley <matthltc@...ibm.com>
To:	"Randy.Dunlap" <rdunlap@...otime.net>
Cc:	Dave Hansen <haveblue@...ibm.com>, devel@...nvz.org,
	Andrew Morton <akpm@...l.org>, Rik van Riel <riel@...hat.com>,
	Chandra Seetharaman <sekharan@...ibm.com>,
	Greg KH <greg@...ah.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andi Kleen <ak@...e.de>, Christoph Hellwig <hch@...radead.org>,
	Andrey Savochkin <saw@...ru>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Rohit Seth <rohitseth@...gle.com>,
	Oleg Nesterov <oleg@...sign.ru>
Subject: Re: [Devel] [PATCH 1/6] BC: kconfig

On Wed, 2006-08-23 at 15:32 -0700, Randy.Dunlap wrote:
> On Wed, 23 Aug 2006 15:13:42 -0700 Matt Helsley wrote:
> 
> > On Wed, 2006-08-23 at 15:04 -0700, Dave Hansen wrote:
> > > On Wed, 2006-08-23 at 15:01 +0400, Kirill Korotaev wrote:
> > > > --- ./arch/sparc64/Kconfig.arkcfg	2006-07-17 17:01:11.000000000 +0400
> > > > +++ ./arch/sparc64/Kconfig	2006-08-10 17:56:36.000000000 +0400
> > > > @@ -432,3 +432,5 @@ source "security/Kconfig"
> > > >  source "crypto/Kconfig"
> > > >  
> > > >  source "lib/Kconfig"
> > > > +
> > > > +source "kernel/bc/Kconfig"
> > > ...
> > > > --- ./arch/sparc64/Kconfig.arkcfg	2006-07-17 17:01:11.000000000 +0400
> > > > +++ ./arch/sparc64/Kconfig	2006-08-10 17:56:36.000000000 +0400
> > > > @@ -432,3 +432,5 @@ source "security/Kconfig"
> > > >  source "crypto/Kconfig"
> > > >  
> > > >  source "lib/Kconfig"
> > > > +
> > > > +source "kernel/bc/Kconfig"
> > > 
> > > Is it just me, or do these patches look a little funky?  Looks like it
> > > is trying to patch the same thing into the same file, twice.  Also, the
> > > patches look to be -p0 instead of -p1.  
> > 
> > They do appear to be -p0
> > 
> > 	They aren't adding the same thing twice to the same file. This patch
> > makes different arches source the same Kconfig.
> 
> Look again.  There are 2 diffstat blocks and 2 of these at least:
> 
> --- ./kernel/bc/Kconfig.bckm	2006-07-28 13:07:38.000000000 +0400
> +++ ./kernel/bc/Kconfig	2006-07-28 13:09:51.000000000 +0400
> @@ -0,0 +1,25 @@
> 
> 
> > 	I seem to recall Chandra suggested that instead of doing it this way it
> > would be more appropriate to add the source line to init/Kconfig because
> > it's more central and arch-independent. I tend to agree.
> 
> ---
> ~Randy

My mistake, Dave is right.

Cheers,
	-Matt Helsley

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/