| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Aug 2006 22:50:00 -0700 (PDT) From: David Miller <davem@...emloft.net> To: ebrower@...il.com Cc: linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org Subject: Re: sym53c8xx PCI card broken in 2.6.18 From: "Eric Brower" <ebrower@...il.com> Date: Tue, 22 Aug 2006 22:35:14 -0700 > Would you consider assigning -1 to lenp (if provided) in > of_find_property() when no matching device is found? I think checking for NULL should be the first thing a caller of these interfaces should do. So from that perspective, I don't think putting anything in *lenp makes sense. It's value is undefined. In fact since we'll leave *lenp alone if the property doesn't exist, you can initialize it to -1 if you want to simplify your checks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists