linux-kernel - [PATCH] eCryptfs: mntput() lower mount on umount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20060824200245.GB3117@us.ibm.com>
Date:	Thu, 24 Aug 2006 15:02:45 -0500
From:	Michael Halcrow <mhalcrow@...ibm.com>
To:	akpm@...l.org
Cc:	linux-kernel@...r.kernel.org, mhalcrow@...ibm.com
Subject: [PATCH] eCryptfs: mntput() lower mount on umount_begin()

On unmount, eCryptfs needs to decrement the mount count of the lower
mount, or else you cannot unmount the lower filesystem.

Signed-off-by: Michael Halcrow <mhalcrow@...ibm.com>

---

 fs/ecryptfs/super.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

bcc1939b87a3df14a9b975bdfde47dd5b230a6e5
diff --git a/fs/ecryptfs/super.c b/fs/ecryptfs/super.c
index 120f060..f4f06ea 100644
--- a/fs/ecryptfs/super.c
+++ b/fs/ecryptfs/super.c
@@ -144,10 +144,7 @@ static void ecryptfs_clear_inode(struct 
 /**
  * ecryptfs_umount_begin
  *
- * Called in do_umount() if the MNT_FORCE flag was used and this
- * function is defined.  See comment in linux/fs/super.c:do_umount().
- * Used only in nfs, to kill any pending RPC tasks, so that subsequent
- * code can actually succeed and won't leave tasks that need handling.
+ * Called in do_umount().
  */
 static void ecryptfs_umount_begin(struct vfsmount *vfsmnt, int flags)
 {
@@ -155,6 +152,7 @@ static void ecryptfs_umount_begin(struct
 		ecryptfs_dentry_to_lower_mnt(vfsmnt->mnt_sb->s_root);
 	struct super_block *lower_sb;
 
+	mntput(lower_mnt);
 	lower_sb = lower_mnt->mnt_sb;
 	if (lower_sb->s_op->umount_begin)
 		lower_sb->s_op->umount_begin(lower_mnt, flags);
-- 
1.3.3

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/