linux-kernel - Re: [PATCH] NFS: Check lengths more thoroughly in NFS4 readdir XDR decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1156449905.5629.68.camel@localhost>
Date:	Thu, 24 Aug 2006 16:05:04 -0400
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...l.org, akpm@...l.org, aviro@...hat.com,
	steved@...hat.com, linux-kernel@...r.kernel.org,
	nfsv4@...ux-nfs.org
Subject: Re: [PATCH] NFS: Check lengths more thoroughly in NFS4 readdir XDR
	decode

On Thu, 2006-08-24 at 20:45 +0100, David Howells wrote:
> Trond Myklebust <trond.myklebust@....uio.no> wrote:
> 
> > No. I find that mixture of < and <= is much less easy to read. Besides,
> > the compiler should be able to optimise that for me.
> 
> So you don't think they're mathematically equivalent?

The fact that they are mathematically equivalent does not make them
equivalently easy to read.

As long as the compiler is able to optimise it, we should be quite free
to choose one or the other style of code.

I therefore chose the style which explicitly lists the number of 32-bit
words we want to scan.

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/