| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Aug 2006 01:49:51 +0400
From: Alexey Dobriyan <adobriyan@...il.com>
To: Andrew Morton <akpm@...l.org>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...ts.osdl.org
Subject: [PATCH 2/2] asus_acpi: don't printk on writing garbage to proc files
* This reporting is useless (you get errno anyway).
* This reporting is already inconsistent in driver.
* Looks like created files in proc are rw-rw-rw- by default.
Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
---
drivers/acpi/asus_acpi.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
--- a/drivers/acpi/asus_acpi.c
+++ b/drivers/acpi/asus_acpi.c
@@ -617,9 +617,7 @@ proc_write_ledd(struct file *file, const
"Asus ACPI: LED display write failed\n");
else
hotk->ledd_status = (u32) value;
- } else if (rv < 0)
- printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
-
+ }
return rv;
}
@@ -837,10 +835,7 @@ proc_write_brn(struct file *file, const
value = (0 < value) ? ((15 < value) ? 15 : value) : 0;
/* 0 <= value <= 15 */
set_brightness(value);
- } else if (rv < 0) {
- printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
}
-
return rv;
}
@@ -885,9 +880,6 @@ proc_write_disp(struct file *file, const
rv = parse_arg(buffer, count, &value);
if (rv > 0)
set_display(value);
- else if (rv < 0)
- printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
-
return rv;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists