linux-kernel - Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060824055226.GB1952@elf.ucw.cz>
Date:	Thu, 24 Aug 2006 07:52:26 +0200
From:	Pavel Machek <pavel@....cz>
To:	Lennart Poettering <mzxreary@...inter.de>
Cc:	len.brown@...el.com, rubini@...vis.unipv.it,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try

Hi!

> Please merge! 
> 
> I wonder who's the right one to ask for merging, since this driver
> sits in drivers/misc/. According to MAINTAINERS Alessandro Rubini
> maintains that directory. However it's somewhat based on the ACPI EC
> access stuff I posted earlier, hence the APCI tree might be another
> path to get this merged. Len, Alessandro, which one of you shall I
> bug to get this driver commited?

I guess Andrew is right person to get this in, but please follow
SubmittingPatches w.r.t. changelog.

> +/* $Id: msi-laptop.c 115 2006-08-20 20:02:54Z lennart $ */

Can you kill this? It only causes problems...

> +/*
> + * msi-laptop.c - MSI S270 laptop support. This laptop is sold under
> + * various brands, including "Cytron/TCM/Medion/Tchibo MD96100".
> + *
> + * This driver exports a few files in /sys/devices/platform/msi-laptop-pf/:
> + *
> + *   lcd_level - Screen brightness: contains a single integer in the
> + *   range 0..8. (rw)
> + * 
> + *   auto_brightness - Enable automatic brightness control: contains
> + *   either 0 or 1. If set to 1 the hardware adjusts the screen
> + *   brightness automatically when the power cord is
> + *   plugged/unplugged. (rw)
> + *
> + *   wlan - WLAN subsystem enabled: contains either 0 or 1. (ro)
> + *
> + *   bluetooth - Bluetooth subsystem enabled: contains either 0 or 1
> + *   Please note that this file is constantly 0 if no Bluetooth
> + *   hardware is available. (ro)

User level documentation should go to Documentation/ somewhere. Not
sure if we have centralized place for /sys docs?

> +/*** Hardware access ***/

Can you remove extra ** s? They hurt my eyes.

> +static int set_lcd_level(int level) {

Indentation (you have this one detail consistently wrong).
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/