linux-kernel - Re: [BUG[[PATCH] register_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20060825115024.076F.Y-GOTO@jp.fujitsu.com>
Date:	Fri, 25 Aug 2006 11:52:20 +0900
From:	Yasunori Goto <y-goto@...fujitsu.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Andrew Morton <akpm@...l.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [BUG[[PATCH] register_one_node compile fix.

Looks good.
Thanks.

Acked-by: Yasunori Goto <y-goto@...fujitsu.com>

> register_one_node()'s should be defined under CONFIG_NUMA=n.
> fixes following bug.
> --
>   CC	  init/version.o
>   LD	  init/built-in.o
>   LD	  .tmp_vmlinux1
> mm/built-in.o: In function `add_memory':
> : undefined reference to `register_one_node'
> --
> 
> Signed-Off-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> 
> Index: linux-2.6.18-rc4/include/linux/node.h
> ===================================================================
> --- linux-2.6.18-rc4.orig/include/linux/node.h
> +++ linux-2.6.18-rc4/include/linux/node.h
> @@ -30,12 +30,20 @@ extern struct node node_devices[];
>  
>  extern int register_node(struct node *, int, struct node *);
>  extern void unregister_node(struct node *node);
> +#ifdef CONFIG_NUMA
>  extern int register_one_node(int nid);
>  extern void unregister_one_node(int nid);
> -#ifdef CONFIG_NUMA
>  extern int register_cpu_under_node(unsigned int cpu, unsigned int nid);
>  extern int unregister_cpu_under_node(unsigned int cpu, unsigned int nid);
>  #else
> +static inline int register_one_node(int nid)
> +{
> +	return 0;
> +}
> +static inline int unregister_one_node(int nid)
> +{
> +	return 0;
> +}
>  static inline int register_cpu_under_node(unsigned int cpu, unsigned int nid)
>  {
>  	return 0;
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Yasunori Goto 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/