linux-kernel - Re: platform device / driver question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060825133933.GC2287@flint.arm.linux.org.uk>
Date:	Fri, 25 Aug 2006 14:39:33 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Jan Bernatik <jan.bernatik@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: platform device / driver question

On Fri, Aug 25, 2006 at 03:08:51PM +0200, Jan Bernatik wrote:
> I studied smc91x driver to understand how platform driver / device
> subsystem works. On #kernelnewbies channel I was told this driver is
> "hopelessly broken". How should one create and register the
> platform_device/driver ? Is the implementation in smc91x correct ?

That's probably from some ill-informed person.  As far as I'm aware,
the driver works perfectly and uses the driver model correctly.

There are some aspects of the driver which are less good (such as all
the machine specific configuration gunk in smc91x.h) but apart from
that, it's fine.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/