linux-kernel - Re: [PATCH 03/17] BLOCK: Stop fallback_migrate_page() from using page_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Aug 2006 15:10:14 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/17] BLOCK: Stop fallback_migrate_page() from using page_has_buffers() [try #2]

On Thu, Aug 24, 2006 at 10:32:58PM +0100, David Howells wrote:
> From: David Howells <dhowells@...hat.com>
> 
> Stop fallback_migrate_page() from using page_has_buffers() since that might not
> be available.  Use PagePrivate() instead since that's more general.

We should document somewhere where to use which of those functions,
especially as they are currently 100% functionally identical.

Also if we ever get private data for anything but buffers these kinds of
checks in generic code will cause problems.  Maybe we should just
kill the default fallback in this case?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/