linux-kernel - Re: [RFC][PATCH 4/4] Rename lock_cpu_hotplug/unlock_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060825035328.GA6322@in.ibm.com>
Date:	Fri, 25 Aug 2006 09:23:28 +0530
From:	Gautham R Shenoy <ego@...ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Nick Piggin <nickpiggin@...oo.com.au>,
	Arjan van de Ven <arjan@...radead.org>, ego@...ibm.com,
	rusty@...tcorp.com.au, torvalds@...l.org, akpm@...l.org,
	linux-kernel@...r.kernel.org, arjan@...el.linux.com,
	davej@...hat.com, dipankar@...ibm.com, vatsa@...ibm.com,
	ashok.raj@...el.com
Subject: Re: [RFC][PATCH 4/4] Rename lock_cpu_hotplug/unlock_cpu_hotplug

On Thu, Aug 24, 2006 at 05:00:26PM +0200, Ingo Molnar wrote:
> 
> * Nick Piggin <nickpiggin@...oo.com.au> wrote:
> 
> > It really is just like a reentrant rw semaphore... I don't see the 
> > point of the name change, but I guess we don't like reentrant locks so 
> > calling it something else might go down better with Linus ;)
> 
> what would fit best is a per-cpu scalable (on the read-side) 
> self-reentrant rw mutex. We are doing cpu hotplug locking in things like 
> fork or the slab code, while most boxes will do a CPU hotplug event only 
> once in the kernel's lifetime (during bootup), so a classic global 
> read-write lock is unjustified.

I agree. However, I was not sure if anything else other than for cpu_hotplug,
needs a self-reentrent rwmutex in the kernel. 
Which is why I did not expose the locking(at least the write side of it)
outside. We don't want too many lazy programmers anyway! 

However, even in case of cpu_hotplug, if we want to prevent
a hotplug event in some critical region where we are not going to sleep, 
we may as well use preempt_disable[/enable]. Because __stop_machine_run waits 
for all the tasks in the fast-path to complete before it changes
the online_cpus map, if I am not mistaken.

Only when you want your local online cpu_map to remain intact when 
you wake up from sleep, should you use cpu_hotplug *lock*.

Ingo?

-- 
Gautham R Shenoy
Linux Technology Center
IBM India.
"Freedom comes with a price tag of responsibility, which is still a bargain,
because Freedom is priceless!"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/