linux-kernel - Re: [PATCH 1/3] kthread: update s390 cmm driver to use kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060825143842.GA27364@infradead.org>
Date:	Fri, 25 Aug 2006 15:38:42 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	"Serge E. Hallyn" <serue@...ibm.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, schwidefsky@...ibm.com
Subject: Re: [PATCH 1/3] kthread: update s390 cmm driver to use kthread

On Thu, Aug 24, 2006 at 04:22:42PM -0500, Serge E. Hallyn wrote:
> Update the s390 cooperative memory manager, which can be a module,
> to use kthread rather than kernel_thread, whose EXPORT is deprecated.
> 
> This patch compiles and boots fine, but I don't know how to really
> test the driver.

NACK.  Please do a real conversion to the kthread paradigm instead of
doctoring around the trivial bits that could be changed with a script.

Please use kthread_should_stop() and remove the cmm_thread_wait
waitqueue in favour of wake_up_process.  The timer useage could
probably be replaced with smart usage of schedule_timeout().
Also the code seems to miss a proper thread termination on module
removal.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/