linux-kernel - Re: [PATCH -mm] x86_64: Adjust the timing of initializing cyc2ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200608251855.57671.ak@suse.de>
Date:	Fri, 25 Aug 2006 18:55:57 +0200
From:	Andi Kleen <ak@...e.de>
To:	Toyo Abe <toyoa@...sta.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] x86_64: Adjust the timing of initializing cyc2ns_scale.

On Friday 25 August 2006 18:45, Toyo Abe wrote:
> The x86_64-mm-monotonic-clock.patch in 2.6.18-rc4-mm2 made a change to
> the updating of monotonic_base. It now uses cycles_2_ns().
> 
> I suggest that a set_cyc2ns_scale() should be done prior to the setup_irq().
> Because cycles_2_ns() can be called from the timer ISR right after the irq0
> is enabled.

Added thanks. I folded it into the original patch.

Did you actually see a failure or was this just from code review?
-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/