linux-kernel - Re: [PATCH 1/2] Add SATA support to libsas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060825194338.GA6020@andromeda.dapyr.net>
Date:	Fri, 25 Aug 2006 15:43:38 -0400
From:	Konrad Rzeszutek <konradr@...ibm.com>
To:	"Darrick J. Wong" <djwong@...ibm.com>
Cc:	linux-scsi@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alexis Bruemmer <alexisb@...ibm.com>
Subject: Re: [PATCH 1/2] Add SATA support to libsas

On Thu, Aug 10, 2006 at 07:19:47PM -0700, Darrick J. Wong wrote:
> Hook the scsi_host_template functions in libsas to delegate
> functionality to libata when appropriate.
> 
> Signed-off-by: Darrick J. Wong <djwong@...ibm.com>
> 
> diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
> index b0705ee..76bbb9f 100644
> --- a/drivers/scsi/libsas/sas_discover.c
> +++ b/drivers/scsi/libsas/sas_discover.c

(...)

>  /* ---------- Domain device ---------- */
> @@ -626,4 +634,8 @@ void sas_unregister_devices(struct sas_h
>  
>  void sas_init_dev(struct domain_device *);
>  
> +extern void sas_target_destroy(struct scsi_target *);
> +extern int sas_slave_alloc(struct scsi_device *);
> +extern int sas_ioctl(struct scsi_device *sdev, int cmd, void __user *arg);
> +

Those should not be 'extern' otherwise the EXPORT_SYMBOL functions 
won't be found when the aic94xx is built as a module.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/