linux-kernel - Re: [ckrm-tech] [RFC][PATCH] UBC: user resource beancounters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1156541845.1196.49.camel@linuxchandra>
Date:	Fri, 25 Aug 2006 14:37:25 -0700
From:	Chandra Seetharaman <sekharan@...ibm.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Kyle Moffett <mrmacman_g4@....com>, Rik van Riel <riel@...hat.com>,
	ckrm-tech@...ts.sourceforge.net, Andi Kleen <ak@...e.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	Andrey Savochkin <saw@...ru>, devel@...nvz.org,
	rohitseth@...gle.com, hugh@...itas.com,
	Ingo Molnar <mingo@...e.hu>, Kirill Korotaev <dev@...ru>,
	Pavel Emelianov <xemul@...nvz.org>
Subject: Re: [ckrm-tech] [RFC][PATCH] UBC: user resource beancounters

On Fri, 2006-08-25 at 21:46 +0100, Alan Cox wrote:
> Ar Gwe, 2006-08-25 am 11:21 -0700, ysgrifennodd Chandra Seetharaman:
> > But, the problem is that the struct user_beancounter (part of
> > wombat_controller above) is a _copy_ of the original, not the original
> > itself. We cannot keep the original (in _each_ controller), as there may
> > be more than one controller in the system 
> 
> Why would you want more than one controller for a given beancounter (and
> thus a single measured resource). Can you give an example ?
> 

Hmm... from what I see, data structure user_beancounter is _not_ defined
for a single resource, it is a beancounter for _all_ resources.

struct user_beancounter
{
	atomic_t		ub_refcount;
	spinlock_t		ub_lock;
	uid_t			ub_uid;
	struct hlist_node	hash;

	struct user_beancounter	*parent;
	void			*private_data;

	/* resources statistics and settings */
	struct ubparm		ub_parms[UB_RESOURCES];
};

ub_parms of _all_ controllers are held in this data structure.

So, keeping the beancounter data structure inside _a_ controller
specific data structure doesn't sound right to me, as other controllers
might also have the same need ?!

Controller _owns_ only ub_parms[controller_id], not the whole
user_beancounter, right ?

-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan@...ibm.com   |      .......you may get it.
----------------------------------------------------------------------


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/