linux-kernel - Re: [PATCH 4/4] eCryptfs: ino

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22796.1156542677@warthog.cambridge.redhat.com>
Date:	Fri, 25 Aug 2006 22:51:17 +0100
From:	David Howells <dhowells@...hat.com>
To:	Michael Halcrow <mhalcrow@...ibm.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] eCryptfs: ino_t to u64 for filldir 

Michael Halcrow <mhalcrow@...ibm.com> wrote:

> filldir()'s inode number is now type u64 instead of ino_t.

Btw, in ecryptfs_interpose(), you have:

	inode = iget(sb, lower_inode->i_ino);

But you have to be *very* *very* careful doing that.  i_ino may be ambiguous.
My suggestions to make i_ino bigger were turned down by Al Viro; and even it
were bigger, it might still not be unique.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/