linux-kernel - Re: drivers/char/synclink_gt.c: chars don't have more than 8 bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Aug 2006 21:49:22 -0500
From:	Paul Fulghum <paulkf@...rogate.com>
To:	Adrian Bunk <bunk@...sta.de>
CC:	linux-kernel@...r.kernel.org
Subject: Re: drivers/char/synclink_gt.c: chars don't have more than 8 bits

Adrian Bunk wrote:
> The GNU C compiler (SVN version) spotted the following buggy code in 
> drivers/char/synclink_gt.c:
> ...
  > Since there are no bits 8 or 9 in a char this code is currently
> dead code.

Yes, that is a bug.

Status and data come in byte pairs, bits 9 and 8 are
referenced from the 16 bit combination.

The code is operating on individual bytes in the buffer,
so it should be bits 1 and 0 that are tested.

I will make a patch and post it.

Thanks,
Paul


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/